transport/grpc.NewClient assumes service name has prefix "pb"

[willfaught]

It's possible for a proto file to have something like this:

option go_package = "pb";

package github_com.mycompany.myrepo.myservice.pb;

in which case the Go package is pb but the GRPC namespace is github_com.mycompany.myrepo.myservice.pb.

There should at least be an option to override the pb default.

[basvanbeek]

The default in Go kit is for the GRPC namespace to be pb. However it is perfectly fine to alter the namespace and do something like:

kitgrpc.NewClient(
    conn, 
    "github_com.mycompany.myrepo.myservice.pb.MyService",
    "MyMethod",
     ...,
)

[willfaught]

You're right, my bad! I missed the period condition. Thanks.

[terinjokes]

If you don't provide a "package" in your protobuf file, your endpoints won't prefixed at all. Enforcing a default of "pb" in the grpc transport that I can't opt out of means I now can't call this service.

[terinjokes]

In my fork, I've added a ClientOption to revert the auto-prefixing. Happy to send a PR, but I think removing, or modifying, the prefixing functionality makes more sense.