Time unit mismatch in statsd metrics Observe()

[esenac]

Hi @peterbourgon!
We are using statsd for metrics, and it seems we found a mismatch in time units between metrics/statsd.Timingand metrics.Timer.
Timer's ObserveDuration method calculate the elapsed time in seconds and passes it to the underlying Histogram's Observe method, that in case of statsd.Timing requires the parameter in milliseconds.
It would be nice to have the chance to specify the time unit measure for ObserveDuration in Timer constructor or at least to be compliant with the underlying method.

[peterbourgon]

metrics.Timer was not built to be compatible with statsd.Timing! But I would be happy to accept a PR that changed the unit on a metrics.Timer. So as not to needlessly break the API, I guess it should be implemented as a new method on the Timer struct, e.g. Unit(time.Duration), with an implied default of time.Second.

[esenac]

Opened PR #610!

[nicolaiskogheim]

This should be closed, right? :)

[esenac]

@nicolaiskogheim yep, thanks.