Skip to content

Comments

fix invalid endpoint no return error#1005

Closed
ytsingshao wants to merge 1 commit intogo-kit:masterfrom
ytsingshao:master
Closed

fix invalid endpoint no return error#1005
ytsingshao wants to merge 1 commit intogo-kit:masterfrom
ytsingshao:master

Conversation

@ytsingshao
Copy link

pass "grpc.WithBlock()" to block until the underlying connection is up.

pass "grpc.WithBlock()" to block until the underlying connection is up.
@peterbourgon
Copy link
Member

Thanks for the PR! Please be sure to gofmt the code, and please include a test which fails on master and succeeds on your branch.

@peterbourgon
Copy link
Member

Ping :)

@sagikazarmark
Copy link
Contributor

#1009 might fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants