fix log stdlibadapter when prefixed#1036
Merged
peterbourgon merged 4 commits intogo-kit:masterfrom Nov 25, 2020
Merged
Conversation
log/stdlib.go
Outdated
| return func(a *StdlibAdapter) { a.messageKey = key } | ||
| } | ||
|
|
||
| // Prefix sets value of the prefix for the actual log message. By default, there's no prefix. |
Member
There was a problem hiding this comment.
What does setting the prefix do?
Contributor
Author
There was a problem hiding this comment.
It allows client code to use the adapter for stdlib logger which is set by the prefix. There is an example in the issue.
Member
There was a problem hiding this comment.
Can you please add some more detail to the doc comment?
Contributor
Author
|
looks like something wrong with the CI |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.