Conversation
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
ChrisHines
left a comment
There was a problem hiding this comment.
I'm not a gRPC expert, so I can't really validate all of the changes here. I do find it fascinating that go mod tidy doesn't make any changes to go.sum in this case, but that reproduces for me locally. Looks good as far as I can tell, though.
|
Most of the changes are in the code generator, but the new proto library should be backwards compatible with the old one. The rest of the changes only affect tests, not the library itself. I guess the reason for no go.sum changes is that there are no observed changes in the list of dependencies: the new proto lib is a dependency of the old one (or vice versa?) and probably something else relies on the old library as well, so it doesn't disappear from |
This PR updates protobuf (with the relevant generators) and the related generated (and version controlled) code.
The code was generated using the following Nix shell setup:
Related to #1109