Merged
Conversation
ChrisHines
reviewed
Jun 24, 2021
| github.com/golang/protobuf v1.5.2 | ||
| github.com/google/btree v1.0.0 // indirect | ||
| github.com/hashicorp/consul/api v1.3.0 | ||
| github.com/hashicorp/consul/api v1.8.1 |
Member
There was a problem hiding this comment.
Looks like v1.9.0 just came out.
Contributor
Author
There was a problem hiding this comment.
Thanks! Updated
Contributor
Author
There was a problem hiding this comment.
Turns out that 1.9.0 requires Go 1.16 (it uses io.Discard added in that version), so I reverted the update for now. If a decision is made that making Go kit 1.16 only is fine, we can upgrade it, but I'd probably wait for Go 1.17 so we can support at least two versions.
Member
There was a problem hiding this comment.
OK, good to know. Agreed on maintaining 1.15 compatibility for now. Last I checked the go-kit policy is to support the current and previous Go release.
sagikazarmark
force-pushed
the
dep-updates
branch
from
4b6d35f to
500974c
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
force-pushed
the
dep-updates
branch
from
500974c to
b68039e
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
force-pushed
the
dep-updates
branch
from
b68039e to
5fef71e
Compare
ChrisHines
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates various "smaller" dependencies that doesn't need a separate PR.
Related #1109