Conversation
sagikazarmark
left a comment
There was a problem hiding this comment.
LGTM
Let's update the rest of the libraries before tagging 0.12. I can take care of that if you want me to.
|
It's easy enough for me to do it. I'll add another commit here soon. |
|
Well, now the race detector is failing Thoughts? |
|
The eureka tests are flaky. Haven't been able to figure out why, but then again, it'll probably be deprecated and removed at some point. |
| matrix: # Support latest and one minor back | ||
| go: ['1.15', '1.16'] | ||
| matrix: # Support latest and one minor back | ||
| go: ["1.16", "1.17"] |
There was a problem hiding this comment.
Just for the record this pulls the latest patch release for each minor, which is what we wan't but wasn't obvious to me.
There was a problem hiding this comment.
Yes. I double checked the logs to make sure it did that because I wasn't sure either.
|
This PR was the last item in the v0.12.0 milestone. Is there anything else we want to do before a new release? |
|
I don't have anything else. |
See commit messages for details.
There are more dependencies that we could upgrade, but I only upgraded
github.com/go-kit/logso far. Here's the list of possible upgrades at this moment:Should we bump any of these?