Skip to content

Use errors.Is for error handling #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbourgon merged 1 commit into from
Sep 28, 2021
Merged

Use errors.Is for error handling #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sd/consul/instancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (s *Instancer) loop(lastIndex uint64) {
index := lastIndex
instances, index, err = s.getInstances(lastIndex, s.quitc)
switch {
case err == errStopped:
case errors.Is(err, errStopped):
return // stopped via quitc
case err != nil:
s.logger.Log("err", err)
Expand Down
2 changes: 1 addition & 1 deletion transport/http/jsonrpc/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ func TestServerBadEncode(t *testing.T) {
func TestServerErrorEncoder(t *testing.T) {
errTeapot := errors.New("teapot")
code := func(err error) int {
if err == errTeapot {
if errors.Is(err, errTeapot) {
return http.StatusTeapot
}
return http.StatusInternalServerError
Expand Down
2 changes: 1 addition & 1 deletion transport/http/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func TestServerBadEncode(t *testing.T) {
func TestServerErrorEncoder(t *testing.T) {
errTeapot := errors.New("teapot")
code := func(err error) int {
if err == errTeapot {
if errors.Is(err, errTeapot) {
return http.StatusTeapot
}
return http.StatusInternalServerError
Expand Down
2 changes: 1 addition & 1 deletion transport/nats/subscriber_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func TestSubscriberErrorEncoder(t *testing.T) {

errTeapot := errors.New("teapot")
code := func(err error) error {
if err == errTeapot {
if errors.Is(err, errTeapot) {
return err
}
return errors.New("dang")
Expand Down