Update github.com/hashicorp/serf and github.com/hashicorp/consul/api to fix CVE-2019-19794#1250
Conversation
This fully deprecate github.com/miekg/dns@v1.0.14 due to security vuln CVE-2019-19794. This PR close issue go-kit#1249.
|
For the record, version bumps like this aren't necessary in intermediary Go projects like Go kit, because the version is determined by the downstream consumer. I'm happy to merge simple PRs like this one, but there is no security issue here, really. |
62dab9e to
ede5915
Compare
|
Hello, thank you very much for considering the PR. Particularly in our projects, the change would be convenient because the applications we have that search for code vulnerabilities mark kit as a vulnerable dependency because it has a transitive dependency with a vulnerable version of dns. |
Any tool which does this is incorrect 🤷 |
|
It's also worth noting that changes like this don't propagate to a wide audience until Go kit tags a new release. Someone would have to run |
This PR update github.com/hashicorp/serf and github.com/hashicorp/consul/api in order to fully deprecate github.com/miekg/dns@v1.0.14 due to CVE-2019-19794 security vuln.
Issue #1249