[WIP] sd/etcd:started to work on a periodical registrar#355
Closed
pdaures wants to merge 2 commits intogo-kit:masterfrom
pdaures:etcd-periodical-registrar
Closed
[WIP] sd/etcd:started to work on a periodical registrar#355pdaures wants to merge 2 commits intogo-kit:masterfrom pdaures:etcd-periodical-registrar
pdaures wants to merge 2 commits intogo-kit:masterfrom
pdaures:etcd-periodical-registrar
Conversation
sd/etcd/periodic_registrar.go
Outdated
|
|
||
| // NewPeriodicRegistrar returns a etcd Registrar with recurring registeation acting on the provided catalog | ||
| // registration (service). | ||
| func NewPeriodicRegistrar(client Client, service Service, logger log.Logger, frequencySec, expirationSec int) *PeriodicRegistrar { |
Member
There was a problem hiding this comment.
Please use time.Duration instead of int
Member
|
Overall direction looks good to me. I'll withhold further comments until you think it's in a ready-for-review state. I'll also update the title to reflect the fact it's a work in progress. |
peterbourgon
changed the title
Member
|
@pdaures Do you want me to take a look at this more thoroughly now? |
Member
|
This was completed in #413. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in Progress.
@peterbourgon please comment on the current structure, names and don't hesitate to ask for changes.