Skip to content

Comments

Enhance package log docs.#429

Merged
ChrisHines merged 2 commits intomasterfrom
log-docs
Jan 11, 2017
Merged

Enhance package log docs.#429
ChrisHines merged 2 commits intomasterfrom
log-docs

Conversation

@ChrisHines
Copy link
Member

Addresses #346 and #415.

Copy link
Member

@peterbourgon peterbourgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


wg.Wait()

// Unordered output:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, didn't know that was a thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterbourgon It was added in Go 1.7 but I was surprised to discover it missing from the docs at golang.org/pkg/testing. There is an oblique reference in the release notes, but the best place to find it is by running go help testfunc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad I could help.. I had basically the exact same issue with a library I wrote a while back so I figured it would be useful.. the deploy became complicated because godoc has to be backwards compatible so that kind of became a crap show for deployments. =(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants