Simplify and fix unstable test#550
Merged
peterbourgon merged 1 commit intogo-kit:masterfrom Jun 8, 2017
yurishkuro:ys-fix-549
Merged
Simplify and fix unstable test#550peterbourgon merged 1 commit intogo-kit:masterfrom yurishkuro:ys-fix-549
peterbourgon merged 1 commit intogo-kit:masterfrom
yurishkuro:ys-fix-549
Conversation
Member
|
💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #549
The order in which subscribers are notified is unpredictable because channels are stored in a map. My bad, was trying to fit too much in one test.
I split testing two subscribers into another function TestRegistry, which simplified the main test.