update grpc readme information about protoc and streams#557
Merged
peterbourgon merged 4 commits intogo-kit:masterfrom Jul 15, 2017
Merged
update grpc readme information about protoc and streams#557peterbourgon merged 4 commits intogo-kit:masterfrom
peterbourgon merged 4 commits intogo-kit:masterfrom
Conversation
transport/grpc/README.md
Outdated
| If you're starting a greenfield project, Go kit strongly recommends gRPC as your default transport. | ||
| And using gRPC and Go kit together is very simple. | ||
|
|
||
| One important note is that while gRPC supports streaming requests and replies, go-kit does not. You can still use streams in your service, but their implementation will not be able to take advantage of many go-kit features like middleware. |
Member
There was a problem hiding this comment.
Please wrap at 80 columns. Also, "Go kit", not "go-kit".
peterbourgon
requested changes
Jun 27, 2017
Member
peterbourgon
left a comment
peterbourgon
left a comment
There was a problem hiding this comment.
Just a couple of nits. Thanks!
Member
|
Ping? :) |
Author
|
sorry, I apparently was not receiving notifications for conversations and PRs. that's fixed and now I'm gonna fix this |
Author
|
@peterbourgon style changes up |
Author
|
let me know if you want me to squash these |
Member
|
Thanks! |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
update grpc readme information about protoc and streams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@peterbourgon
As per our conversation in Slack, a link to the protocol releases page and some information about streams and go-kit. Let me know if any wording should be changed. Thanks!