Skip to content

Comments

Remove unnecessary error check.#581

Merged
ChrisHines merged 1 commit intogo-kit:masterfrom
cam-stitt:logger-marshaler-error
Jul 20, 2017
Merged

Remove unnecessary error check.#581
ChrisHines merged 1 commit intogo-kit:masterfrom
cam-stitt:logger-marshaler-error

Conversation

@cam-stitt
Copy link
Contributor

@cam-stitt cam-stitt commented Jul 20, 2017

#580

If you want to see the test fail, just add the error interface in the test without removing the error type check.

gokit-logger

@ChrisHines ChrisHines merged commit e10f5bf into go-kit:master Jul 20, 2017
@ChrisHines
Copy link
Member

Perfect. Thanks!

Fixes #580.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants