updated thrift to latest Go library adding support for context#585
Merged
peterbourgon merged 1 commit intogo-kit:masterfrom Jul 26, 2017
Merged
updated thrift to latest Go library adding support for context#585peterbourgon merged 1 commit intogo-kit:masterfrom
peterbourgon merged 1 commit intogo-kit:masterfrom
Conversation
Member
Author
|
travis has an unrelated build failure: |
Member
|
What, that's garbage, the env var is clearly set in Travis..... argh |
Member
https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings 😠 |
Member
|
@basvanbeek Sorry, can you rebase on master? |
Member
|
Leeroy Jenkins |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
updated thrift to latest Go library adding support for context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our addsvc example we supply a thrift transport which due to the api change in the Thrift Go library was broken.
This PR adds the support for context.Context as found in the latest Thrift Go library.