Example stringsvc updated to reflect gokit.io#638
Merged
peterbourgon merged 2 commits intogo-kit:masterfrom Dec 7, 2017
wadearnold:example-stringsvc
Merged
Example stringsvc updated to reflect gokit.io#638peterbourgon merged 2 commits intogo-kit:masterfrom wadearnold:example-stringsvc
peterbourgon merged 2 commits intogo-kit:masterfrom
wadearnold:example-stringsvc
Conversation
Change the order of the code in the example/stringsvc1 so that it flows with the tutorial on gokit.io
StringService interface should have a Context in its service definition. File does not match the tutorial on gokit.io
Member
|
Thanks! |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
* Example/stringsvc1 updated file flow to mimic tutorial on gokit.io Change the order of the code in the example/stringsvc1 so that it flows with the tutorial on gokit.io * Stringsvc1 is missing Context in StringService interface StringService interface should have a Context in its service definition. File does not match the tutorial on gokit.io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a documentation update pull request to remove discrepancies between the example stringsvc1 and the tutorial on the gokit website. Just trying to make the intro to go-kit as simple as possible.