Zipkin tracing support (Native v2)#671
Merged
peterbourgon merged 11 commits intogo-kit:masterfrom Mar 12, 2018
Merged
Conversation
Member
|
Gave it a quick review. Thanks for updating the tests and examples. |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
* Added new Zipkin tracing middleware using the native zipkin-go library * new approach to Zipkin tracing middleware for Go kit * improvements to zipkin tracer docs and code * source comments changes * Adds http test. * Adds endpoint test. * Improves code based on idiomatic feedback. * updates to tracing doc comments * do not allow to activate both zipkin-go and zipkin-go-opentracing to avoid confusion * add test for zipkin http server tracer * add test for zipkin grpc server and client tracers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds native Zipkin support for the HTTP and gRPC transports.
It is a more idiomatic implementation benefiting people using Zipkin in their polyglot microservice environment and lowers the amount of necessary boilerplate in Go kit compared to the OpenTracing implementation by allowing for global service middleware setup.