Handle JSON RPC errors. Resolves issue #672.#673
Conversation
peterbourgon
left a comment
peterbourgon
left a comment
There was a problem hiding this comment.
Minus the comment thing, if you're happy, I'm happy :)
| // request object. It's designed to be used in JSON RPC clients, for | ||
| // DecodeResponseFunc extracts a user-domain response object from an JSONRPC | ||
| // response object. It's designed to be used in JSON RPC clients, for | ||
| // client-side endpoints. One straightforward DecodeRequestFunc could be |
There was a problem hiding this comment.
Oops, looks like a copy/paste flub in the comment! Probably there are others of these, too. Also, does the actual comment from this point on make sense?
There was a problem hiding this comment.
Thanks for spotting that. I've made some tweaks to the doc comments in that file.
|
I think this looks tidy now. I'll be using it in anger in the near future, so will feed back if there are any other tweaks needed. |
|
@peterbourgon before merge I'd like to play a bit with it... can you wait max. a day until merge? |
|
@basvanbeek I'll wait until you ping me again 👍 |
|
Failures are related to the Thrift nonsense, so I'm gonna optimistically merge. |
* Handle JSON RPC errors. Resolves issue go-kit#672. * Refactor decode func to receive JSON RPC response. Remove error func. * Comment tweaks.
3 participants
No description provided.