Adds documentation for OpenCensus in tracing readme and package doc#730
Merged
peterbourgon merged 2 commits intogo-kit:masterfrom Jul 16, 2018
Merged
Adds documentation for OpenCensus in tracing readme and package doc#730peterbourgon merged 2 commits intogo-kit:masterfrom
peterbourgon merged 2 commits intogo-kit:masterfrom
Conversation
yurishkuro
reviewed
Jul 16, 2018
tracing/README.md
Outdated
| The following tracing back-ends are known to work with Go kit through the | ||
| OpenTracing interface and are highlighted in the [addsvc] example. | ||
|
|
||
| ## OpenCensus |
Contributor
There was a problem hiding this comment.
looks like the wrong place in the readme, doesn't work with the previous sentence.
Member
Author
There was a problem hiding this comment.
you are right, moving the section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed OpenCensus did not have a package doc nor a section in our tracing readme.