Conversation
- add installation and running instructions - add disclaimer - add introdctory note on experimental nature of the project
- github markdown apparently fails to keep track of `1. - 1. - 1.` style list if block code is involved - thought it was the double space at the end of the code block, but removing didn't help
Contributor
Author
|
👇🏻haven't touched those failing tests. |
ermik
commented
Aug 4, 2018
| PostProfile(ctx context.Context, p Profile) error | ||
| // ... | ||
| } | ||
| type Profile struct { |
Contributor
Author
There was a problem hiding this comment.
@nyarly I went off your profilesvc example in writing this, and now I realize that kitgen doesn't work on an input containing type definitions (and single interface). Not sure what's up.
Contributor
Author
Member
|
This seems reasonable to me but I'll wait for a plus-one from @nyarly |
Contributor
Author
|
@peterbourgon perhaps add him as a reviewer? |
Contributor
|
LGTM. Sorry about the delay here. I didn't remember that there was a dependency on inlinefiles. Should look at that and see if it can be migrated to the more conventional go:generate pattern. |
Contributor
Author
|
@nyarly if you want a tester — I am running kitgen almost daily atm. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This measly PR with absolutely no code change and no performance improvements seeks to address #639 with a bit of note-taking.
/request @nyarly