Merged
Conversation
3 tasks
peterbourgon
requested changes
Aug 22, 2018
Member
peterbourgon
left a comment
peterbourgon
left a comment
There was a problem hiding this comment.
Thanks, one thing though.
transport/http/client.go
Outdated
| "github.com/go-kit/kit/endpoint" | ||
| ) | ||
|
|
||
| // HTTPClient is an interface for http clients |
Member
There was a problem hiding this comment.
Please use proper spelling and punctuation.
// HTTPClient is an interface that models *http.Client.
Contributor
Author
|
fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use HTTPClient interface instead of *http.Client in transport to facilitate use of http middlewares.
#753