Rename "package log" to "log package" to fix godoc link handling.#765
Merged
ChrisHines merged 1 commit intogo-kit:masterfrom Sep 18, 2018
Merged
Rename "package log" to "log package" to fix godoc link handling.#765ChrisHines merged 1 commit intogo-kit:masterfrom
ChrisHines merged 1 commit intogo-kit:masterfrom
Conversation
bx2
force-pushed
the
fix/763-log-package-rename
branch
from
e1549de to
c79e33f
Compare
log/level/doc.go
Outdated
| @@ -1,4 +1,4 @@ | |||
| // Package level implements leveled logging on top of package log. To use the | |||
| // Package level implements leveled logging on top of log package. To use the | |||
Member
There was a problem hiding this comment.
Well, let's be grammatically correct: "...on top of Go kit's log package."
bx2
force-pushed
the
fix/763-log-package-rename
branch
from
c79e33f to
9a3e541
Compare
ChrisHines
approved these changes
Sep 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #763.