Skip to content

Comments

metrics/internal/convert: use method value insetad of lambda#767

Merged
peterbourgon merged 1 commit intogo-kit:masterfrom
quasilyte:quasilyte/unlambda
Oct 1, 2018
Merged

metrics/internal/convert: use method value insetad of lambda#767
peterbourgon merged 1 commit intogo-kit:masterfrom
quasilyte:quasilyte/unlambda

Conversation

@quasilyte
Copy link

Method value signature matches expected callback signature,
so there is no need in explicit lambda wrapping.

Method value signature matches expected callback signature,
so there is no need in explicit lambda wrapping.
@quasilyte
Copy link
Author

CI failure looks unrelated to the change:

#!/bin/bash -eo pipefail
go get -t github.com/go-kit/kit/...

# github.com/miekg/dns
../../miekg/dns/msg_helpers.go:271:8: undefined: strings.Builder
../../miekg/dns/serve_mux.go:43:9: undefined: strings.Builder
Exited with code 2

@peterbourgon peterbourgon merged commit 81cf14a into go-kit:master Oct 1, 2018
@quasilyte quasilyte deleted the quasilyte/unlambda branch October 2, 2018 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants