Skip to content

Comments

Influx import rewrite#826

Merged
peterbourgon merged 1 commit intogo-kit:masterfrom
flowchartsman:825-fix-influx-import
Jan 17, 2019
Merged

Influx import rewrite#826
peterbourgon merged 1 commit intogo-kit:masterfrom
flowchartsman:825-fix-influx-import

Conversation

@flowchartsman
Copy link
Contributor

fixes #825

@flowchartsman
Copy link
Contributor Author

The CircleCI failures appear unrelated:

=== RUN   TestIntegration
component=registrar key=/services/foosvc/1.2.3.4:8080 value=http://1.2.3.4:8080 action=register
component=instancer prefix=/services/foosvc/ instances=1
==================
WARNING: DATA RACE
Read at 0x00c0001fc028 by goroutine 9:
  github.com/go-kit/kit/sd/etcdv3.(*client).close()
      /home/circleci/.go_workspace/src/github.com/go-kit/kit/sd/etcdv3/client.go:229 +0x69
  github.com/go-kit/kit/sd/etcdv3.(*client).Deregister()
      /home/circleci/.go_workspace/src/github.com/go-kit/kit/sd/etcdv3/client.go:220 +0x1d9
  github.com/go-kit/kit/sd/etcdv3.(*Registrar).Deregister()
      /home/circleci/.go_workspace/src/github.com/go-kit/kit/sd/etcdv3/registrar.go:84 +0xe8
  github.com/go-kit/kit/sd/etcdv3.runIntegration()
      /home/circleci/.go_workspace/src/github.com/go-kit/kit/sd/etcdv3/integration_test.go:79 +0xb73
  github.com/go-kit/kit/sd/etcdv3.TestIntegration()
      /home/circleci/.go_workspace/src/github.com/go-kit/kit/sd/etcdv3/integration_test.go:144 +0x3c6
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:827 +0x162

Previous write at 0x00c0001fc028 by goroutine 27:
  github.com/go-kit/kit/sd/etcdv3.(*client).WatchPrefix()
      /home/circleci/.go_workspace/src/github.com/go-kit/kit/sd/etcdv3/client.go:145 +0x306

Goroutine 9 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:878 +0x650
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1119 +0xa8
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:827 +0x162
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1117 +0x4ee
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1034 +0x2ee
  main.main()
      _testmain.go:54 +0x221

Goroutine 27 (running) created at:
  github.com/go-kit/kit/sd/etcdv3.(*Instancer).loop()
      /home/circleci/.go_workspace/src/github.com/go-kit/kit/sd/etcdv3/instancer.go:44 +0x100
==================
component=registrar key=/services/foosvc/1.2.3.4:8080 value=http://1.2.3.4:8080 action=deregister
--- FAIL: TestIntegration (0.12s)
    integration_test.go:26: GetEntries("/services/foosvc/1.2.3.4:8080"): [] (OK)
    integration_test.go:37: Registered
    integration_test.go:59: Constructed Instancer OK
    integration_test.go:67: Constructed Endpointer OK
    integration_test.go:76: Endpointer saw Register OK
    integration_test.go:80: Deregistered
    integration_test.go:85: Checking Deregister: len(endpoints) = 1, err = <nil>
    integration_test.go:85: Checking Deregister: len(endpoints) = 0, err = <nil>
    integration_test.go:99: GetEntries("/services/foosvc/1.2.3.4:8080"): [] (OK)
    testing.go:771: race detected during execution of test

@peterbourgon
Copy link
Member

Thanks!

@peterbourgon peterbourgon merged commit 8a8a1bb into go-kit:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Influxdb client location changed

2 participants