adds NopResponse to AMQP transport#850
Merged
peterbourgon merged 1 commit intogo-kit:masterfrom Mar 26, 2019
Merged
Conversation
Merged
Member
|
This leaves a bad taste in my mouth, because we're not doing RPC anymore. But I guess it fits the model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to previous discussion and #841, here is a commit that allows users to configure AMQP Subscriber to not issue a response to the sender. Similiarly, one is also able to configure AMQP Consumer to not wait for a response.
Comments/ Suggestions are more than welcome.