Skip to content

Comments

Fix drift from aws sdk#860

Closed
nelz9999 wants to merge 1 commit intogo-kit:masterfrom
nelz9999:cw2-fix-ctx
Closed

Fix drift from aws sdk#860
nelz9999 wants to merge 1 commit intogo-kit:masterfrom
nelz9999:cw2-fix-ctx

Conversation

@nelz9999
Copy link
Contributor

Fixes #856

@peterbourgon
Copy link
Member

Unfortunately not..

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7f0895]

goroutine 11 [running]:
net/http.(*Request).WithContext(...)
	/usr/local/go/src/net/http/request.go:353
github.com/aws/aws-sdk-go-v2/aws.setRequestContext(...)
	/home/build/go/src/github.com/aws/aws-sdk-go-v2/aws/request_context.go:11
github.com/aws/aws-sdk-go-v2/aws.(*Request).SetContext(...)
	/home/build/go/src/github.com/aws/aws-sdk-go-v2/aws/request.go:226
github.com/aws/aws-sdk-go-v2/service/cloudwatch.PutMetricDataRequest.Send(0xc0000bca00, 0xc00000e800, 0x0, 0x93e320, 0xc00001c080, 0x5cb003c6, 0xc000030760, 0x4a8a27)
	/home/build/go/src/github.com/aws/aws-sdk-go-v2/service/cloudwatch/api.go:1146 +0xc5
github.com/go-kit/kit/metrics/cloudwatch2.(*CloudWatch).Send.func2(0x0, 0x0)
	/home/build/go/src/github.com/go-kit/kit/metrics/cloudwatch2/cloudwatch2.go:169 +0x2de
golang.org/x/sync/errgroup.(*Group).Go.func1(0xc0000133b0, 0xc0000133e0)
	/home/build/go/src/golang.org/x/sync/errgroup/errgroup.go:57 +0x65
created by golang.org/x/sync/errgroup.(*Group).Go
	/home/build/go/src/golang.org/x/sync/errgroup/errgroup.go:54 +0x74
FAIL	github.com/go-kit/kit/metrics/cloudwatch2	0.018s

@peterbourgon
Copy link
Member

@nelz9999 Seems like this might be solved over in #857, do you want to review that?

@peterbourgon
Copy link
Member

Obviated by #857.

@nelz9999
Copy link
Contributor Author

Ahh, cool. Sorry I missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kit/metrics/cloudwatch2: fails to build

2 participants