Use supplied context in NATS endpoint constructor#876
Merged
peterbourgon merged 1 commit intogo-kit:masterfrom May 29, 2019
nsmith5:fix/nats-context
Merged
Use supplied context in NATS endpoint constructor#876peterbourgon merged 1 commit intogo-kit:masterfrom nsmith5:fix/nats-context
peterbourgon merged 1 commit intogo-kit:masterfrom
nsmith5:fix/nats-context
Conversation
Contributor
Author
|
Build seems to be broken due to #877 |
Member
|
Thanks! Can you rebase on master? |
Previous implementation used a new background context which prevented context cancellation.
Contributor
Author
|
Yep, done |
Member
|
Thank you! |
Contributor
Author
|
Not a problem! Thanks for the clear issue labels. It was very easy to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous implementation used a new background context which prevented proper context cancellation.
Fixes #869.