Clarify rate limiter expressions in addsvc example#943
Merged
peterbourgon merged 1 commit intogo-kit:masterfrom Jan 1, 2020
Merged
Clarify rate limiter expressions in addsvc example#943peterbourgon merged 1 commit intogo-kit:masterfrom
peterbourgon merged 1 commit intogo-kit:masterfrom
Conversation
Member
|
The different ways to express rate limits and burst capacity are properties of the rate limiting package, and it's expected that users will read those docs to learn more. It's not clear to me that your changes are strictly or even generally easier to understand, so I'm -1 on a wholesale change, but I'd welcome a change to one example, and comments (like you have in the comments) on both examples explaining what the expressions mean. |
Rate limiting examples might be a bit confusing when Every method is used go-kit#698. One could expect to see throttling expressed as a number of requests per unit of time whereas another would see it as an interval between requests.
Contributor
Author
|
I added comments to |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
Rate limiting examples might be a bit confusing when Every method is used go-kit#698. One could expect to see throttling expressed as a number of requests per unit of time whereas another would see it as an interval between requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rate limiting examples might be a bit confusing when
rate.Everymethod is used #698.Naturally one would expect to see a throttling demo as a number of requests per unit of time
instead of defining an interval between requests.