Improve inconsistent Consul SD index handling.#999
Merged
peterbourgon merged 1 commit intogo-kit:masterfrom Jul 20, 2020
schmidtw:master
Merged
Improve inconsistent Consul SD index handling.#999peterbourgon merged 1 commit intogo-kit:masterfrom schmidtw:master
peterbourgon merged 1 commit intogo-kit:masterfrom
schmidtw:master
Conversation
Consul has guidelines for how the index movement should be handled. https://www.consul.io/api-docs/features/blocking#implementation-details Generally the index should always increase but if it does not increase this patch implements the suggested solutions for recovery.
Contributor
Author
|
This should fix #997 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consul has guidelines for how the index movement should be handled.
https://www.consul.io/api-docs/features/blocking#implementation-details
Generally the index should always increase but if it does not increase this
patch implements the suggested solutions for recovery.