Updates for Go 1.17

[ChrisHines]

I want to update this package and tag a patch release before updating go-kit/kit in go-kit/kit#1105. I've already updated both of this package's dependencies along the same lines. Just working my way up the tree to minimize the number of new releases and maximize the benefit of the Go 1.17 module pruning feature for consumers.

[ChrisHines]

@peterbourgon ping.

[sagikazarmark]

Should we tag this change, so we can make the ones in the kit repo?

[peterbourgon]

@sagikazarmark Can you clarify? I see this as part of the next milestone...

[ChrisHines]

This package still has a dependency on github.com/go-stack/stack that is only used in tests. We could probably find a way to remove that dependency and therefore drop it from the go.mod file. If that is worth doing then it makes sense to hold off on tagging a release until we had that change in place.

[sagikazarmark]

@peterbourgon My understanding is that tagging the log package blocks advancing to the Go 1.17 change in the kit repo. At least that was my assumption based on Chris's first comment.

@ChrisHines let me take a look at dropping the stack dependency.

[ChrisHines]

It's not so much blocking the Go 1.17 change in the kit repo, but without it some the module graph pruning behavior of Go 1.17 would not apply to the log package. So the optimal sequence is to tag log first, then update the go.mod file in kit and tag kit.

[sagikazarmark]

I think we are ready for that, aren't we? I managed to get rid of the stack package.

[ChrisHines]

I saw your PR. I'll review it later when I have a block of time. I expect to make a couple of comments to see if we can simplify.

[peterbourgon]

We can tag a new release, sure. Does the bump to 1.17 warrant 0.2.0 or can we get away with 0.1.1?

[sagikazarmark]

@ChrisHines it's already merged, but I'm happy to followup.

@peterbourgon My default answer would be 0.2.0, but I have no strong opinion on the matter.

[ChrisHines]

@sagikazarmark Ahh, in that case I might tinker with it on my own tonight and see if I find any improvements. In any case, thanks for making the change. :)

Regarding version. I did a patch bump on some other packages, but only the go version in the go.mod changed in those cases. In this case, since we're removing a dependency, I think v0.2.0 seems slightly more appropriate.

[peterbourgon]

I'll do that in a couple hours unless there's an objection. Should it be immediately followed by any action in kit?

[sagikazarmark]

No objection. Chris's followup PR was also merged, so I think we are good.

The next action in kit would be updating the log module in go-kit/kit#1105 and finishing up the PR for merging.

[ChrisHines]

Yep, we should be good to tag this repo.

[peterbourgon]

https://github.com/go-kit/log/releases/tag/v0.2.0