Remove "go1.10" build tag from driver #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2019 08:09
Some IDEs and editors refuse to acknowledge the "go1.10" build tag when autocompleting & compiling. Removing said tag increases usibility of the library for those stuck with these editors.
methane
requested changes
Oct 21, 2019
Member
methane
left a comment
methane
left a comment
There was a problem hiding this comment.
Please remove driver_go110.go and driver_go110_test.go, and move all code into driver.go and driver_test.go.
Closed
methane
approved these changes
Dec 12, 2019
reireias
added a commit
to reireias/mysql
that referenced
this pull request
Dec 12, 2019
This reverts commit b66d043.
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
Some IDEs and editors refuse to acknowledge the "go1.10" build tag when autocompleting & compiling. Removing said tag increases usibility of the library for those stuck with these editors.
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
Some IDEs and editors refuse to acknowledge the "go1.10" build tag when autocompleting & compiling. Removing said tag increases usibility of the library for those stuck with these editors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some IDEs and editors seem to not acknowledge the "go1.10" build tag when
autocompleting & compiling. Removing said tag increases usibility of the
library for those stuck with these editors.
Checklist
Created tests which fail without the change (if possible)(N/A)Extended the README / documentation, if necessary(N/A)