enhance(metrics)!: query parameter support on metrics endpoint#682
Merged
enhance(metrics)!: query parameter support on metrics endpoint#682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
- Coverage 55.20% 55.07% -0.13%
==========================================
Files 201 201
Lines 15916 15952 +36
==========================================
Hits 8786 8786
- Misses 6752 6788 +36
Partials 378 378
|
cognifloyd
previously approved these changes
Aug 10, 2022
Member
cognifloyd
left a comment
There was a problem hiding this comment.
I don't use the metrics endpoint so far, but this looks sane from reading.
wass3r
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what?
this adds query parameter support to the
/metricsendpoint.why?
without selective querying, the
/metricsendpoint will perform expensive and exhaustive queries to retrieve information from the databasebreaking change!
the default values for each query parameter are
falseso that you must selectively request additional information from the database, which means anyone using the/metricsendpoint as it works currently will stop receiving data unless they update their query fromcurl 'localhost:8080/metrics'to
curl 'localhost:8080/metrics?user_count=t&build_count=true'and include each piece of data they would like to query for.
docs
once i get approval on the structure and usage of the parameters i will create the documentation before merging