Conversation
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
- Coverage 55.10% 55.09% -0.01%
==========================================
Files 201 201
Lines 15960 15959 -1
==========================================
- Hits 8794 8793 -1
Misses 6788 6788
Partials 378 378
|
wass3r
approved these changes
Sep 12, 2022
plyr4
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed:
nolintleading spacing issuegofmtran on all filesreviveto thenolintdirective incontext_test.goReadHeaderTimeoutto the server to protect against Slowloris attacksgofmtutcoption in theloggercode since its declared astrueeverywhere in the code and the editing ofendinside that function was resulting in an unused variable linter errorio/ioutilto be eitheriooros