Skip to content

chore: address #722 review feedback#780

Merged
ecrupper merged 5 commits intomainfrom
chore/database/feedback
Mar 15, 2023
Merged

chore: address #722 review feedback#780
ecrupper merged 5 commits intomainfrom
chore/database/feedback

Conversation

@jbrockopp
Copy link
Copy Markdown
Contributor

Based off of #722

This attempts to address all the review feedback provided from that PR:

#722 (review)

Additionally, I attempted to find and fix a few typos in other packages.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2023

Codecov Report

Merging #780 (725c58f) into main (a3ab6f0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #780   +/-   ##
=======================================
  Coverage   54.87%   54.87%           
=======================================
  Files         244      244           
  Lines       16506    16506           
=======================================
  Hits         9058     9058           
  Misses       7048     7048           
  Partials      400      400           
Impacted Files Coverage Δ
database/hook/index.go 100.00% <100.00%> (ø)
database/log/get.go 88.46% <100.00%> (ø)
database/log/get_service.go 88.46% <100.00%> (ø)
database/log/get_step.go 88.46% <100.00%> (ø)
database/log/index.go 100.00% <100.00%> (ø)
database/log/list.go 76.92% <100.00%> (ø)
database/repo/index.go 100.00% <100.00%> (ø)

@ecrupper ecrupper merged commit 214b2bd into main Mar 15, 2023
@ecrupper ecrupper deleted the chore/database/feedback branch March 15, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants