Skip to content

Conversation

@PeshekDotDev
Copy link
Contributor

Details

This PR implements str methods so errors are easier to understand while debugging


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@PeshekDotDev PeshekDotDev self-assigned this Dec 5, 2025
@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 5773768
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69406e48ab5d5300087d929a

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 5773768
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69406e48343ed6000807c600
😎 Deploy Preview https://deploy-preview-18628--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 5773768
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69406e485f3e5900081532ba
😎 Deploy Preview https://deploy-preview-18628--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.38%. Comparing base (1dd7269) to head (606cbf9).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18628      +/-   ##
==========================================
+ Coverage   93.12%   93.38%   +0.25%     
==========================================
  Files         949      949              
  Lines       52254    52269      +15     
==========================================
+ Hits        48663    48811     +148     
+ Misses       3591     3458     -133     
Flag Coverage Δ
conformance 38.79% <80.00%> (+0.01%) ⬆️
e2e 44.69% <80.00%> (+1.03%) ⬆️
integration 23.45% <80.00%> (+0.02%) ⬆️
unit 91.59% <100.00%> (+<0.01%) ⬆️
unit-migrate 91.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-606cbf93c2f1009669ce6f1869f53fdc14980e20
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-606cbf93c2f1009669ce6f1869f53fdc14980e20

Afterwards, run the upgrade commands from the latest release notes.

@PeshekDotDev PeshekDotDev marked this pull request as ready for review December 14, 2025 23:28
@PeshekDotDev PeshekDotDev requested a review from a team as a code owner December 14, 2025 23:28
@PeshekDotDev PeshekDotDev changed the title scim: update error logging lib: update error logging Dec 14, 2025
Comment on lines 17 to 27
def __str__(self):
if self.response is not None:
if hasattr(self.response, "json"):
try:
return f"Network error: {self.response.json()}"
except JSONDecodeError:
pass
if hasattr(self.response, "text"):
return f"Network error: {self.response.text}"
return f"Network error: {self.response}"
return "Network error communicating with remote system"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to BaseSyncException

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

@PeshekDotDev PeshekDotDev moved this from Todo to Needs review in authentik Core Dec 19, 2025
@github-project-automation github-project-automation bot moved this from Needs review to In Progress in authentik Core Dec 30, 2025
@PeshekDotDev PeshekDotDev merged commit fdb7fa6 into main Jan 5, 2026
301 of 316 checks passed
@PeshekDotDev PeshekDotDev deleted the SCIM-error-improvement branch January 5, 2026 15:44
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Jan 5, 2026
kensternberg-authentik added a commit that referenced this pull request Jan 5, 2026
* main: (149 commits)
  lib: update error logging (#18628)
  core, web: update translations (#19179)
  web: bump @formatjs/intl-listformat from 8.1.0 to 8.1.1 in /web (#19182)
  ci: bump getsentry/action-release from 3.4.0 to 3.5.0 (#19183)
  web: bump knip from 5.78.0 to 5.79.0 in /web (#19181)
  lifecycle: fix migration conn_options for psycopg connection (#19134)
  website/docs: remove duplicates in slo docs (#19170)
  web/admin: adjust sync threshold, add tooltip (#19131)
  web: Fix user library colors, modal z-indexes, table progress bars (#19152)
  web: fix slug auto-updating when editing existing applications (#19169)
  core: handle deserialization errors from FileField migration (#19067)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#19137)
  website/integrations: vaultwarden: add custom email scope (#19160)
  ci: bump int128/docker-manifest-create-action from 2.10.0 to 2.12.0 (#19138)
  core, web: update translations (#19135)
  web: bump globals from 16.5.0 to 17.0.0 in /web (#19154)
  web/user: fix consent delete form missing details (#19147)
  web: Token Form Fixes (#19121)
  website/docs: fix build (#19148)
  website/docs: endpoint agent release notes (#19042)
  ...
kensternberg-authentik added a commit that referenced this pull request Jan 5, 2026
* main: (43 commits)
  web/maintenance: no missing element type definitions (#18950)
  core: add prettier failure on duplicate group names (#18941)
  website/integrations: make grafana terraform section expand (#19192)
  lib: update error logging (#18628)
  core, web: update translations (#19179)
  web: bump @formatjs/intl-listformat from 8.1.0 to 8.1.1 in /web (#19182)
  ci: bump getsentry/action-release from 3.4.0 to 3.5.0 (#19183)
  web: bump knip from 5.78.0 to 5.79.0 in /web (#19181)
  lifecycle: fix migration conn_options for psycopg connection (#19134)
  website/docs: remove duplicates in slo docs (#19170)
  web/admin: adjust sync threshold, add tooltip (#19131)
  web: Fix user library colors, modal z-indexes, table progress bars (#19152)
  web: fix slug auto-updating when editing existing applications (#19169)
  core: handle deserialization errors from FileField migration (#19067)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#19137)
  website/integrations: vaultwarden: add custom email scope (#19160)
  ci: bump int128/docker-manifest-create-action from 2.10.0 to 2.12.0 (#19138)
  core, web: update translations (#19135)
  web: bump globals from 16.5.0 to 17.0.0 in /web (#19154)
  web/user: fix consent delete form missing details (#19147)
  ...
kensternberg-authentik added a commit that referenced this pull request Jan 6, 2026
* main: (38 commits)
  web/maintenance: no missing element type definitions (#18950)
  core: add prettier failure on duplicate group names (#18941)
  website/integrations: make grafana terraform section expand (#19192)
  lib: update error logging (#18628)
  core, web: update translations (#19179)
  web: bump @formatjs/intl-listformat from 8.1.0 to 8.1.1 in /web (#19182)
  ci: bump getsentry/action-release from 3.4.0 to 3.5.0 (#19183)
  web: bump knip from 5.78.0 to 5.79.0 in /web (#19181)
  lifecycle: fix migration conn_options for psycopg connection (#19134)
  website/docs: remove duplicates in slo docs (#19170)
  web/admin: adjust sync threshold, add tooltip (#19131)
  web: Fix user library colors, modal z-indexes, table progress bars (#19152)
  web: fix slug auto-updating when editing existing applications (#19169)
  core: handle deserialization errors from FileField migration (#19067)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#19137)
  website/integrations: vaultwarden: add custom email scope (#19160)
  ci: bump int128/docker-manifest-create-action from 2.10.0 to 2.12.0 (#19138)
  core, web: update translations (#19135)
  web: bump globals from 16.5.0 to 17.0.0 in /web (#19154)
  web/user: fix consent delete form missing details (#19147)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants