libinfinity-0.7.0 doesn't build with format-security

[nirik]

Greetings.

Fedora enables format-security by default, and when I try and build 0.7.0 I get:

make[3]: Entering directory '/builddir/build/BUILD/libinfinity-0.7.0/infinoted'
  CC       libinfinoted_plugin_manager_0_7_la-infinoted-log.lo
  CC       libinfinoted_plugin_manager_0_7_la-infinoted-parameter.lo
  CC       libinfinoted_plugin_manager_0_7_la-infinoted-plugin-manager.lo
  CC       libinfinoted_plugin_manager_0_7_la-infinoted-util.lo
  CC       infinoted_0_7-infinoted-config-reload.o
  CC       infinoted_0_7-infinoted-dh-params.o
  CC       infinoted_0_7-infinoted-main.o
  CC       infinoted_0_7-infinoted-options.o
  CC       infinoted_0_7-infinoted-pam.o
  CC       infinoted_0_7-infinoted-run.o
  CC       infinoted_0_7-infinoted-signal.o
  CC       infinoted_0_7-infinoted-startup.o
infinoted-startup.c: In function 'infinoted_startup_sasl_callback':
infinoted-startup.c:386:16: warning: overflow in implicit constant conversion [-Woverflow]
         cmp |= 0xFF;
                ^~~~
infinoted-startup.c: In function 'infinoted_startup_free':
infinoted-startup.c:522:9: warning: unused variable 'i' [-Wunused-variable]
   guint i;
         ^
infinoted-config-reload.c: In function 'infinoted_config_reload':
infinoted-config-reload.c:123:5: error: format not a string literal and no format arguments [-Werror=format-security]
     );
     ^
infinoted-config-reload.c:238:7: warning: 'plugin_manager' may be used uninitialized in this function [-Wmaybe-uninitialized]
       g_object_unref(plugin_manager);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
infinoted-startup.c: In function 'infinoted_startup_new':
infinoted-startup.c:155:9: warning: 'n_certs' may be used uninitialized in this function [-Wmaybe-uninitialized]
   guint n_certs;
         ^~~~~~~
infinoted-options.c: In function 'infinoted_options_load.constprop':
infinoted-options.c:896:5: warning: 'cmdline_options' may be used uninitialized in this function [-Wmaybe-uninitialized]
     g_hash_table_unref(cmdline_options);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [Makefile:780: infinoted_0_7-infinoted-config-reload.o] Error 1
make[3]: *** Waiting for unfinished jobs....

The full scratch build is at: https://koji.fedoraproject.org/koji/taskinfo?taskID=17262600

Happy to test patches or provide more info. Thanks.

[aburgm]

Thanks for bringing that up! I tried to compile with -Werror=format-security and fixed two instances in fdd7d51. Note that in both cases I don't expect any serious security issues because in one case the format string is only controlled by translations and in the other it is the strerror output (and the latter is only a test executable that does not get installed).

Please re-open if there are any other issues!