Various fixes and features#1
Merged
aburgm merged 4 commits intogobby:masterfrom Jun 30, 2014
polarina:master
Merged
Conversation
Contributor
|
Thanks very much for the contribution! I have added some comments to some individual commits. Do you think you can change the pull request accordingly? |
Contributor
|
By the way, I have seen that you have also added more patches to the Gobby bugtracker. Do you plan to create pull requests for those as well, or should I have a look at the individual patches in the bugtracker? |
Contributor
Author
|
The patches I've added in the Gobby bugtracker are identical to the commits in this pull request. I only added them for completeness. |
…e_user_area The bug manifests itself when show_remote_cursors and show_remote_selections evaluate to FALSE and show_remote_current_lines evaluates to TRUE. Usual symptoms are crashes.
Contributor
Author
|
I've resolved the issues you've pointed out, to the best of my knowledge. How do the patches look now? |
Contributor
|
Very good, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patches fix bug #623, implements enhancement #612, and implements features required for enhancement #626 in Gobby.