Initialize root_directory setting with absolute path

[hph86]

When starting infinoted twice like this

$ ./infinoted-0.7 --root-directory=data --security-policy=no-tls

a warning is emitted and infinoted becomes unusable:

Wed 16 Mar 2016 06:12:15 PM CET] WARNING: Failed to read the ACL for the root node: The pathname 'data/global-acl.xml' is not an absolute path
In order not to compromise security all permissions have been revoked for all users. The infinote server is likely not very usable in this configuration, so please check the storage system, fix the problem and re-start the server.

The ACL file global-acl.xml which is created during first invocation cannot be read during second invocation. The cause seems to be the function infd_filesystem_storage_storage_read_acl().

First, infd_filesystem_storage_get_acl_path() -> infd_filesystem_storage_get_path() is called and it should assure (according to the documentation) to always return an absolute path to said file. However, it only returns an absolute path if the "root-directory" setting was already absolute. Then, infd_filesystem_storage_read_xml_file_impl() -> g_filename_to_uri() is called which expects an absolute path and fails otherwise.

The PR should ensure that priv->root_directory is always initialized with an absolute path. Thus, both relative and absolute settings of --root-directory should now be handled correctly.

[tyll]

#14 should fix the travis-ci here as well

[aburgm]

It seems dangerous to query the current directory every time a path is resolved, because the current directory could change during the lifetime of the program. I'd prefer to ensure that priv->root_directory is absolute at construction time.

[hph86]

Good point I did not think of. Hopefully, I'll find time to rewrite the PR today.

[hph86]

@aburgm: I have just updated the PR according to your suggestion.

[tyll]

travis-ci is unhappy, because it could not access the Ubuntu mirror, which is unrelated to this change. Can the check be re-started?

[aburgm]

I restarted the job and it looks good. Will merge it tonight, hopefully.

[aburgm]

Thanks!