Introduce validation-coding-standards.yml#2452
Merged
EvanHerman merged 18 commits intofeature/github-actions-migrationfrom Dec 2, 2022
Merged
Introduce validation-coding-standards.yml#2452EvanHerman merged 18 commits intofeature/github-actions-migrationfrom
EvanHerman merged 18 commits intofeature/github-actions-migrationfrom
Conversation
EvanHerman
changed the base branch from
feature/github-actions-migration
to
master
kopepasah
changed the base branch from
master
to
feature/github-actions-migration
kopepasah
reviewed
Nov 29, 2022
kopepasah
reviewed
Nov 29, 2022
kopepasah
suggested changes
Nov 29, 2022
Contributor
kopepasah
left a comment
kopepasah
left a comment
There was a problem hiding this comment.
Left a couple comments for review.
EvanHerman
commented
Nov 30, 2022
kopepasah
suggested changes
Nov 30, 2022
Contributor
kopepasah
left a comment
kopepasah
left a comment
There was a problem hiding this comment.
Added some additional feedback.
kopepasah
reviewed
Nov 30, 2022
kopepasah
reviewed
Nov 30, 2022
kopepasah
approved these changes
Dec 1, 2022
Contributor
kopepasah
left a comment
kopepasah
left a comment
There was a problem hiding this comment.
Looks great! Feel free to merge into the actions migration branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce
validation-coding-standards.ymlworkflow file for linting PHP, CSS and JS files.Types of changes
New feature (non-breaking change which adds functionality)
Acceptance criteria
Add github actions workflow to lint PHP, CSS and JS files.
Checklist: