chore: upgrade cassandra-driver to 4.8.0#91
Conversation
Enables Node 24.x support. Please see apache/cassandra-nodejs-driver#429 for details
There was a problem hiding this comment.
Beware that the cassandra-driver changelog is not clear on what Node.js version are actually supported anymore.
Version 4.7.0 states
[NODEJS-653] - Update supported platforms to reflect more modern versions of node.js
And the README reads
The current version of the driver offers support consistent with this policy for the following:
- Node.js versions 18.x, 20.x, and 22.x.
Furthermore they previously explcitly called out when they dropped support for Node.js v4 and v6, but have not called out since then.
Unsure if that means that anything lower than 16 does not work, or just not officialy supported. It's not clear either way under which versions this will work.
The engines property of package.json may want to be updated to reflect this.
Not calling for any changes here, just providing context.
| }, | ||
| "engines": { | ||
| "node": "^10.17.0 || >=12.3.0" | ||
| "node": ">=18.0.0" |
There was a problem hiding this comment.
Not a blocker, but just a call out that this constitutes as a breaking change. Let's make sure to publish this as a new major
There was a problem hiding this comment.
Agreed @rmarkins-godaddy. Looking at the contribution guide, it was not clear to me if I should manually update the change log and version within the package.json or if that is done by maintainers or automation. Do you have any guidance for me? Thanks.
There was a problem hiding this comment.
Yeah that's a good call out as well. Probably should add at least a changelog and allow the merger to handle versioning and publishing. @jpage-godaddy we should add automation around this on the repo in the future
4 participants
Enables Node 24.x support. Please see apache/cassandra-nodejs-driver#429 for details