Add Connect* functions#185
Merged
Merged
Conversation
Member
|
I like the new API here, it makes things generally easier. I'd rather not break compatibility with existing clients again. Leaving the shared vs. private connection doesn't hurt anything. If you wish, you can add documentation to the old bus access methods to say they are deprecated in favor of the new Connect functions to make it clear the new functions are preferred for new clients. |
Member
|
To address another comment in your description; I will support having these new functions be the recommended mechanism for new clients and updating the examples accordingly. |
amenzhinsky
force-pushed
the
add-connect-methods
branch
from
cbed819 to
02ed7b1
Compare
Author
|
@jsouthworth updated tests and examples, please have a look |
Member
|
Looks great! Thanks for following through on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there.
This partially solves problems described in #179 giving a shortcuts to establish connection with the system/session bus without calling
AuthandHelloexplicitly.There's still number of
SystemBusandSessionBuscalls in examples and tests we need to decide connecting which way will be recommended to users.P.S. I'd still recommend to get rid of the conception of shared/private connections.