For the GitHub runner, add scons-arguments and cache-key parameters#66
Closed
Ivorforce wants to merge 1 commit intogodotengine:mainfrom
Closed
For the GitHub runner, add scons-arguments and cache-key parameters#66Ivorforce wants to merge 1 commit intogodotengine:mainfrom
Ivorforce wants to merge 1 commit intogodotengine:mainfrom
Conversation
… parameters in favour of scons-arguments and cache-key parameters. This allows the runner to be used when passing more arguments that aren't covered explicitly, making it more future-proof.
Ivorforce
commented
Nov 8, 2024
| arch: ${{ matrix.arch }} | ||
| float-precision: single | ||
| build-target-type: template_release | ||
| - name: 🔗 GDExtension Build |
Member
Author
There was a problem hiding this comment.
Pretty sure this preset was just broken, as matrix.float-precision wasn't defined.
Member
|
By depreciating float-precision, we assume we're always building for single and double precision. |
Member
Author
|
float-precision can (and should) be passed through the scons-arguments. The functionality itself is not being deprecated. |
Member
Author
|
Noting that I prefer #68 - but don't merge either branch without discussion! |
Member
Author
|
As per GDExtension meeting, we will move the github setup action to godot-cpp. This will be better represented by another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, deprecate float-precision and build-target-type parameters (to be migrated to use scons-arguments instead).
This allows the runner to be used when passing more arguments that aren't covered explicitly, making it more future-proof and compatible with GDExtensions adding their own options.
platform and arch aren't replaced because those parameters are relevant outside the engine, proven by the fact that (at least platform) is used actively as a parameter by the github action.