Support _validate_property()#1239
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Sep 13, 2023
Merged
Conversation
dsnopek
added
the
enhancement
dsnopek
force-pushed
the
gdextension-validate-property-object
branch
from
3eb594f to
255e28e
Compare
Collaborator
Author
|
Per usual, this won't pass tests on CI until after the Godot PR is merged, but it is passing for me locally. I'll be sure to re-run the CI at that point, so we can be sure all is good! |
dsnopek
force-pushed
the
gdextension-validate-property-object
branch
from
255e28e to
efc9836
Compare
Collaborator
Author
|
CI is passing now! It'd be really great if someone could review this, since the Godot PR has already been merged, and until this one is merged, godot-cpp master will be incompatible with Godot master. |
rburing
reviewed
Sep 12, 2023
rburing
approved these changes
Sep 12, 2023
Member
rburing
left a comment
rburing
left a comment
There was a problem hiding this comment.
All looks reasonable and the tests pass.
dsnopek
force-pushed
the
gdextension-validate-property-object
branch
from
efc9836 to
aa6867e
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion PR to Godot PR godotengine/godot#81515
It allows object classes in GDExtension to implement
_validate_property()to alter properties.It includes a unit test that verifies that this functionality actually works!