Skip to content

Fix allocation size overflow check in CowData#1245

Merged
dsnopek merged 1 commit intogodotengine:masterfrom
AThousandShips:alloc_fix
Sep 20, 2023
Merged

Fix allocation size overflow check in CowData#1245
dsnopek merged 1 commit intogodotengine:masterfrom
AThousandShips:alloc_fix

Conversation

@AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Sep 20, 2023

@AThousandShips AThousandShips added bug This has been identified as a bug crash cherrypick:4.1 labels Sep 20, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 20, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner September 20, 2023 11:18
dsnopek
dsnopek approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The patch looks identical to what was just merged in Godot

@dsnopek dsnopek merged commit a3dfbbd into godotengine:master Sep 20, 2023
@AThousandShips AThousandShips deleted the alloc_fix branch September 20, 2023 12:44
@AThousandShips
Copy link
Member Author

AThousandShips commented Sep 20, 2023

Thank you!

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 9, 2023

Cherry-picked for 4.1 in PR #1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees

No one assigned

Labels

bug This has been identified as a bug crash

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

2 participants

@AThousandShips @dsnopek