Fix misunderstandings in GDREGISTER_CLASS (T)#1427
Closed
pupil1337 wants to merge 4 commits intogodotengine:masterfrom
pupil1337:master
Closed
Fix misunderstandings in GDREGISTER_CLASS (T)#1427pupil1337 wants to merge 4 commits intogodotengine:masterfrom pupil1337:master
pupil1337 wants to merge 4 commits intogodotengine:masterfrom
pupil1337:master
Conversation
…ss, compile successed
AThousandShips
added
enhancement
Contributor
Author
|
This PR has been messed up by multiple commits, and the branch is also my master branch. I plan to delete this PR and create a new branch for this modification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to Fix #1425
When I want to register a non abstract class, I will use
GDREGISTER_CLASS()or other macros, But I registered the abstract class throughGDREGISTER_CLASS()(possibly because forgot to implement the pure virtual methods), and there were no compilation errors, which would give me some misunderstandings.It is because
if constexpr (!std::is_abstract_v<T>)determined that this class is an abstract class and did not compilememnew(T).May necessary to confirm that when using GDREGISTER_CLASS(), the
memnew(T)must compile. Therefore, when I mistakenly register an abstract class byGDREGISTER_CLASS(), the compiler will give error message.