Fix vararg methods forwarded to the ClassDB singleton#1485
Merged
dsnopek merged 1 commit intogodotengine:masterfrom Jun 14, 2024
Merged
Fix vararg methods forwarded to the ClassDB singleton#1485dsnopek merged 1 commit intogodotengine:masterfrom
ClassDB singleton#1485dsnopek merged 1 commit intogodotengine:masterfrom
Conversation
dsnopek
added
bug
Collaborator
Author
|
PR #1486 should fix the test failure - it's unrelated to the changes here |
dsnopek
force-pushed
the
classdb-call-static-method
branch
from
045852d to
e04a26b
Compare
Member
|
My bad accidentally made my own fix for this, will make that just an improvement and leave this for the immediate fix |
This was referenced Jun 14, 2024
AThousandShips
approved these changes
Jun 14, 2024
Collaborator
Author
|
Thanks for the review! |
Collaborator
Author
|
Cherry-picked for 4.1 in PR #1491 |
Collaborator
Author
|
Cherry-picked for 4.2 in PR #1492 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to fix the CI issues with Godot PR godotengine/godot#93141 as well as allowing forwarded vararg methods to work.
This will need to be cherry-picked to the
4.2branch before CI on that PR can pass.