Make generated code mostly style compliant#1528
Conversation
|
Thanks! I diffed the I did notice one odd change: - return internal::_call_builtin_operator_ptr<int8_t>(_method_bindings.operator_not, (GDExtensionConstTypePtr)&opaque, (GDExtensionConstTypePtr)nullptr);
+ return internal::_call_builtin_operator_ptr<int8_t>(_method_bindings.operator_not, (GDExtensionConstTypePtr)&opaque, (GDExtensionConstTypePtr) nullptr);It's adding a space before |
|
Will take a look, realized there were some potentially breaking things so will check first, making draft atm |
This is intentional, it's compliant with clang-format Fixed the error, will take a look over it again to make sure I didn't break anything and push soon, and adding some further improvements |
7a8d426 to
f131efb
Compare
|
Will see if I can adjust some minor issues, like empty To confirm this doesn't break things do: then checkout this, run And compare the diffs, it should now just be minor style differences, and no lost code (accidentally removed some |
|
Sorry for taking so long to come back this!
Ah, ok, I didn't know that. I skimmed through the diff between the code generated before and after the latest version of this PR, and I didn't spot any issues, although, it is a very long diff. :-) So, this looks good to me, but I think I'll hold off on actually merging it until after Godot 4.3-stable is released, just in case. |
|
Cherry-picked for 4.2 in PR #1570 |
|
This one won't cleanly cherry-pick to the |
Follow-up to:
This makes running
clang-formaton the generated files change almost nothing, the only things this does not do correctly is:class_db_singleton.hpp, which would be a lot of extra code to make work correctlypublic:followed immediately byprivate:should have no empty line (or nopublic:in the first place), this could be fixed but only occurs in one place, so leaving it be for right now and not adding any complicating code for it