Skip to content

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 26, 2024

Similar to the recent https://github.com/bruvzg/godot-nir-static/ and https://github.com/bruvzg/godot-angle-static/ changes for ARM64 Windows support.

  • Fixes MSVC architecture detection.
  • Adds MinGW-LLVM support.
  • Adds mingw_prefix to specify custom toolchain.

Tested with:

  • MSVC 2022 - (arm64, x86_64, x86_32)
  • MinGW-GCC MSYS2 on Windows - (x86_64, x86_32)
  • MinGW-LLVM on Windows - (arm64, x86_64, x86_32)
  • MinGW-GCC cross build from macOS - (x86_64)
  • MinGW-LLVM cross build from macOS - (x86_64)

@bruvzg bruvzg added enhancement This is an enhancement on the current functionality platform:windows topic:buildsystem Related to the buildsystem or CI setup labels Jul 26, 2024
@bruvzg bruvzg requested a review from a team as a code owner July 26, 2024 06:41
@bruvzg bruvzg force-pushed the llvm-mingw-arm64 branch 3 times, most recently from 7242aa2 to fdcfade Compare July 26, 2024 06:46
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't have a way to test this, but it looks good to me

@dsnopek dsnopek merged commit 4d8c05f into godotengine:master Sep 10, 2024
@dsnopek
Copy link
Collaborator

dsnopek commented Oct 28, 2024

Cherry-picked for 4.2 in PR #1631

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 28, 2024

Cherry-picked for 4.3 in PR #1632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality platform:windows topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants