Rename Vector4.components -> coord#1608
Closed
Ivorforce wants to merge 1 commit intogodotengine:masterfrom
Closed
Conversation
To bring it in-line with all the other vectors.
Member
Author
|
I can see the same discrepancy is present in the Godot repo. What gives? This certainly makes merging this PR a little more debatable... Let's hear what you think. |
AThousandShips
added
enhancement
Member
|
Has to be done in the engine itself first to ensure compatibility between the engine and extensions |
Member
Author
|
I will make a PR to core and see what they say there. |
This was referenced Sep 26, 2024
Member
|
Superseded by: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To bring it in-line with all the other vectors, they all use
coord.I think it's pretty obvious that this is a breaking change, though it will not introduce bugs, just cause people to need to adjust their usages when they update.