SCons: Don't cache libraries #1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
added
enhancement
dsnopek
approved these changes
Oct 5, 2024
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! Seems good to me :-)
Collaborator
|
Cherry-picked for 4.2 in PR #1631 |
Collaborator
|
Cherry-picked for 4.3 in PR #1632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered in one of my PRs on the main repo1 that the cache size for godot-cpp is huge. After a bit more digging, I believe that the main culprits are the library files; the equivalents of which are not cached in the main repo. This PR makes them uncached explicitly.
Footnotes
https://github.com/godotengine/godot/pull/97166#discussion_r1766720006 ↩